BIND 10 trac2203, created. c91bffdd00deb8b7f3ceda9954a84e31c0cfb9f1 [2203] a piggy back fix: prevent redundant initial data configuration.
BIND 10 source code commits
bind10-changes at lists.isc.org
Thu Oct 4 00:32:43 UTC 2012
The branch, trac2203 has been created
at c91bffdd00deb8b7f3ceda9954a84e31c0cfb9f1 (commit)
- Log -----------------------------------------------------------------
commit c91bffdd00deb8b7f3ceda9954a84e31c0cfb9f1
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Oct 3 17:28:41 2012 -0700
[2203] a piggy back fix: prevent redundant initial data configuration.
this addresses the issue described in #2291. Still not really clean,
but thanks to boost::bind we can centralize all the code logic in the
callback, so I think it's now less likely that we forget cleaning it up
when the hack is not necessary.
commit ec6cf17e571f9cf23fd1e7bcd573df55106550b1
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Oct 3 17:17:36 2012 -0700
[2203] changed configurator class to a simple function.
as it's now completely stateless and can work independently.
the common specialization for the main implementation is defined in a
new created .cc file.
commit 746376902a020e0711bc85fc29a2b339a85b3db2
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Oct 3 15:44:29 2012 -0700
[2203] pass server obj to configurator's reconfigure().
now the configurator class is completely stateless.
commit 05136b55f90375a1a7e3a76570cb95bf0590c0ad
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Oct 3 15:24:22 2012 -0700
[2203] refactoring 2nd step: configurator can now be a separate object.
i.e., it's not a singleton any more.
testReconfigure() method isn't needed any more because it doesn't hold
CC session internally.
DatasrcConfiguratorTest.initialization test currently fails and is
disabled for now. The plan is to make the class completely stateless,
at which point we don't even have to think about initialization or cleanup,
and then the test will be able to be removed.
commit 4fa694dbee3372b8c310aca2c2dafc3ca7550e80
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Tue Oct 2 20:38:31 2012 -0700
[2203] changed the callback type of addRemoteConfig to boost::function.
this will make it more convenient, e.g., by allowing the caller to pass
boost::bind encapsulating a class object and a class method.
boost::function is upper compatible to function pointer, so it doesn't
ensure source-level compatibility.
the functor overhead shouldn't matter in this context, and since this module
already uses boost::function this change doesn't introduce additional
dependency.
commit b4bdc9b1f5ec444d1bc4002fe7d65a50acc9d897
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Tue Oct 2 20:24:57 2012 -0700
[2203] refactoring 1st step: move session obj outside of datasrc configurator.
-----------------------------------------------------------------------
More information about the bind10-changes
mailing list