BIND 10 trac2206, updated. 47c013b000db7235e1ab798eadebc3b42984b06e [2206] Make a common function out of duplicate code
BIND 10 source code commits
bind10-changes at lists.isc.org
Thu Oct 4 04:49:55 UTC 2012
The branch, trac2206 has been updated
via 47c013b000db7235e1ab798eadebc3b42984b06e (commit)
from 3d68f767731a682d4a80e9ba74d953502c2ada7d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 47c013b000db7235e1ab798eadebc3b42984b06e
Author: Mukund Sivaraman <muks at isc.org>
Date: Thu Oct 4 10:18:57 2012 +0530
[2206] Make a common function out of duplicate code
-----------------------------------------------------------------------
Summary of changes:
.../tests/memory/zone_table_segment_unittest.cc | 23 +++++++++++---------
1 file changed, 13 insertions(+), 10 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc b/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
index e6a8a97..efee347 100644
--- a/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
+++ b/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
@@ -54,22 +54,25 @@ TEST_F(ZoneTableSegmentTest, create) {
EXPECT_NE(static_cast<void*>(NULL), segment_);
}
-TEST_F(ZoneTableSegmentTest, getHeader) {
- ZoneTableHeader& header = segment_->getHeader();
+// Helper function to check const and non-const methods.
+template <typename TS, typename TH>
+void
+testGetHeader(ZoneTableSegment* segment) {
+ TH& header = static_cast<TS*>(segment)->getHeader();
// The zone table is unset.
- ZoneTable* table = header.getTable();
+ const ZoneTable* table = header.getTable();
EXPECT_EQ(static_cast<void*>(NULL), table);
}
-TEST_F(ZoneTableSegmentTest, getHeaderConst) {
- // Test const methods
- const ZoneTableHeader& header =
- static_cast<const ZoneTableSegment*>(segment_)->getHeader();
+TEST_F(ZoneTableSegmentTest, getHeader) {
+ // non-const version.
+ testGetHeader<ZoneTableSegment, ZoneTableHeader>(segment_);
+}
- // The zone table is unset.
- const ZoneTable* table = header.getTable();
- EXPECT_EQ(static_cast<void*>(NULL), table);
+TEST_F(ZoneTableSegmentTest, getHeaderConst) {
+ // const version.
+ testGetHeader<const ZoneTableSegment, const ZoneTableHeader>(segment_);
}
TEST_F(ZoneTableSegmentTest, getMemorySegment) {
More information about the bind10-changes
mailing list