BIND 10 trac2903, created. b47cd4c09f84751609f52a4a989889a7aa475b2a [2903] more cleanups for SyncUDPServer: avoid constructing objs for each cback.

BIND 10 source code commits bind10-changes at lists.isc.org
Fri Apr 26 07:20:21 UTC 2013


The branch, trac2903 has been created
        at  b47cd4c09f84751609f52a4a989889a7aa475b2a (commit)

- Log -----------------------------------------------------------------
commit b47cd4c09f84751609f52a4a989889a7aa475b2a
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Apr 26 00:19:14 2013 -0700

    [2903] more cleanups for SyncUDPServer: avoid constructing objs for each cback.

commit a354d4ed95f1368c961efabea0eb2e1db95675c3
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 25 21:09:43 2013 -0700

    [2903] further simplify SyncUDPServer: now remove checkin and answer callbacks.
    
    Its constructor and member variables are also simplified accordingly.

commit b154498887ecdedb12bcde74d91d2e76a3f57e1a
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 25 17:02:00 2013 -0700

    [2903] more simplify SyncUDPServer: don't use checkin_callback.

commit db2e9d7c08423014a3aba97ffe3d48d23b3ec28a
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 25 16:48:01 2013 -0700

    [2903] more (unrelated) cleanups for SyncUDPServer, removing dead code.
    
    also, it now rejects NULL lookup callback explicitly as it doesn't make
    sense for this class.  It will also help make the receive handler code
    simpler.

commit 4ee02ef54b1056af032347aca528dd1d78c610e9
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 25 16:16:27 2013 -0700

    [2903] an unrelated small optimization: use const_buffers_1 for send.
    
    asio::buffer is internally converted to this form, so this is (in theory)
    more efficient.

commit 65bbffe7c89169fc958fad642185684154c85aa4
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 25 16:09:44 2013 -0700

    [2903] same change as the previous commit for SyncUDPServer.
    
    also made some other small cleanups.

commit abd65c5b6ee4df38adc9dd03207525b805067544
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 25 15:56:00 2013 -0700

    [2903] make sure UDPServer don't die due to a failure of close().
    
    also don't stop receiving due to errors from async_receive_from().
    some other minor cleanups are made too.

commit c7fd8cf0745b7a13c3ddf0e8309b64c7bdb18f8c
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Apr 24 18:38:15 2013 -0700

    [2903] unrelated style fix: fixed too-long line

commit 11d850685bf9e0d6a46b434fde322463a056c95a
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Apr 24 18:30:17 2013 -0700

    [2903] catch some errors from asio methods/functions explicitly
    
    otherwise it would result in an uncatchable exception and force the
    program to terminate.  some exceptions are still considered super rare
    and fatal, and they are still propagated (mainly from the io_service
    and deadline timer).  errors on close() are just ignored (there
    wouldn't be much we can do to recover in this case anyway).
    
    Further, changed the handling of errors on the result of async_accept():
    instead of stop accepting on some errors, log them and keep accepting
    new connections.  on a closer look at the code I believe that's more
    appropriate; silent stop would be rather confusing (if the error were
    really fatal we should rather invoke an exception and trigger termination),
    and cases like EMFILE definitely shouldn't cause this situation.
    errors that can caused by stop() should still result in stopping accept(),
    and the new code behaves that way.

-----------------------------------------------------------------------



More information about the bind10-changes mailing list