BIND 10 trac2903, updated. de20a4c519712d5076b3e26c6eb1e4a40f689ed8 [2903] more documentation updates

BIND 10 source code commits bind10-changes at lists.isc.org
Fri Apr 26 07:49:31 UTC 2013


The branch, trac2903 has been updated
       via  de20a4c519712d5076b3e26c6eb1e4a40f689ed8 (commit)
      from  b47cd4c09f84751609f52a4a989889a7aa475b2a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit de20a4c519712d5076b3e26c6eb1e4a40f689ed8
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Apr 26 00:49:20 2013 -0700

    [2903] more documentation updates

-----------------------------------------------------------------------

Summary of changes:
 src/lib/asiodns/sync_udp_server.cc |    7 -------
 src/lib/asiodns/sync_udp_server.h  |    6 ++++++
 2 files changed, 6 insertions(+), 7 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/asiodns/sync_udp_server.cc b/src/lib/asiodns/sync_udp_server.cc
index f473bf5..9233f9e 100644
--- a/src/lib/asiodns/sync_udp_server.cc
+++ b/src/lib/asiodns/sync_udp_server.cc
@@ -93,13 +93,6 @@ SyncUDPServer::handleRead(const asio::error_code& ec, const size_t length) {
     }
     // OK, we have a real packet of data. Let's dig into it!
 
-    // The UDP socket class has been extended with asynchronous functions
-    // and takes as a template parameter a completion callback class.  As
-    // UDPServer does not use these extended functions (only those defined
-    // in the IOSocket base class) - but needs a UDPSocket to get hold of
-    // the underlying Boost UDP socket - DummyIOCallback is used.  This
-    // provides the appropriate operator() but is otherwise functionless.
-
     // Make sure the buffers are fresh.  Note that we don't touch query_
     // because it's supposed to be cleared in lookup_callback_.  We should
     // eventually even remove this member variable (and remove it from
diff --git a/src/lib/asiodns/sync_udp_server.h b/src/lib/asiodns/sync_udp_server.h
index 372c458..f6aafce 100644
--- a/src/lib/asiodns/sync_udp_server.h
+++ b/src/lib/asiodns/sync_udp_server.h
@@ -131,10 +131,16 @@ private:
     isc::dns::MessagePtr query_, answer_;
     // The socket used for the communication
     std::auto_ptr<asio::ip::udp::socket> socket_;
+    // Wrapper of socket_ in the form of asiolink::IOSocket.
+    // "DummyIOCallback" is not necessary for this class, but using the
+    // template is the easiest way to create a UDP instance of IOSocket.
     boost::scoped_ptr<asiolink::UDPSocket<asiolink::DummyIOCallback> >
     udp_socket_;
     // Place the socket puts the sender of a packet when it is received
     asio::ip::udp::endpoint sender_;
+    // Wrapper of sender_ in the form of asiolink::IOEndpoint.  It's set to
+    // refer to sender_ on initialization, and keeps the reference throughout
+    // this server class.
     asiolink::UDPEndpoint udp_endpoint_;
     // Callback
     const DNSLookup* lookup_callback_;



More information about the bind10-changes mailing list