[bind10-dev] code reviews

[Jeremy C. Reed]

In mid March, I created a reviewed branch. For now it is called 
branches/REVIEWED. I have been copying reviewed code. I understand we 
have lots more, but most has been changed since was last reviewed or the 
reviews were never completed. I am only doing this as a temporary 
measure to help keep track of the "reviewed code". The plan is to just 
use trunk.

You may commit to the branch, but please note in your svn commit message 
the ticket number (that indicates the review) and/or or who okayed the 
code.

The plan is have trunk used for development, but all changes to it 
reviewed first. If it is very minor (like comment changes or obvious 
typo fix), use your discretion and commit fix without review but clearly 
indicate this in your commit message. If the change is minor, then use 
jabber or email to ask for an okay and mention that in your commit 
message. Else use the review policy as documented at 
http://bind10.isc.org/wiki/CodeReviewProcedure
Be sure to include the ticket number in your svn commit message.

Please read http://bind10.isc.org/wiki/CodeReviewProcedure
- all code reviewed before merged to trunk

(My comments above about very minor or minor changes not requiring a the 
full code review steps aren't documented on the page. If okay, I will 
add it.)

Currently the REVIEWED branch only has:
src/bin/loadzone
src/bin/auth
src/lib/python/isc/auth
src/lib/config

The review tickets still open are:

MsgQ review
http://bind10.isc.org/ticket/22

review needed: configure.ac, Makefile.am and related for main level
http://bind10.isc.org/ticket/35

review: src/bin/bindctl
http://bind10.isc.org/ticket/37

review: src/bin/cfgmgr
http://bind10.isc.org/ticket/38

review: src/bin/cmdctl
http://bind10.isc.org/ticket/39

review: src/bin/bind10
http://bind10.isc.org/ticket/40

review: src/bin/stats
http://bind10.isc.org/ticket/41

review: src/lib/dns/cpp
http://bind10.isc.org/ticket/44

review: truncation support in the DNS message library
http://bind10.isc.org/ticket/94

review: some trivial RDATA classes
http://bind10.isc.org/ticket/96

Review data source and query logic
http://bind10.isc.org/ticket/50

review: NSEC RDATA "from wire" fixes and tests
http://bind10.isc.org/ticket/116

review: case-sensitive name compression
http://bind10.isc.org/ticket/142

review: some cleanups for xfrin
http://bind10.isc.org/ticket/137

review Element class
http://bind10.isc.org/ticket/20

Python ccmsg stuff review
http://bind10.isc.org/ticket/23

Review: Python binding for DNS message API
http://bind10.isc.org/ticket/87

Review: Xfrin
http://bind10.isc.org/ticket/88

review: auth server incorrectly returns SERVFAIL to queries of class ANY
http://bind10.isc.org/ticket/80

review: dnstime
http://bind10.isc.org/ticket/61

review: data source code
http://bind10.isc.org/ticket/64

review: python binding integration
http://bind10.isc.org/ticket/113
(Stalled until jelte does his different research?)

review: some cleanups and minor bug fixes for xfrout
http://bind10.isc.org/ticket/141

review: Module descriptions
http://bind10.isc.org/ticket/90

review: move UNUSED_PARAM to .cc
http://bind10.isc.org/ticket/115

There may be others. And maybe some of above are completed. Or maybe 
some of these are stalled due to other work.