[bind10-dev] a couple of small things about ACL loader

[Michal 'vorner' Vaner]

Hello

On Fri, Jul 01, 2011 at 02:06:51AM -0700, JINMEI Tatuya / 神明達哉 wrote:
> 1. why is CheckCreator::create() not a const member function?
>    Existing examples don't seem to need to modify the class, and
>    considering its nature (essentially it works as a factory), I
>    suspect it can naturally be a const member function.

I probably just overlooked it when writing it. It can safely be constified.

> 2. I'm afraid it's too restrictive to specify the default action
>    through the constructor of Loader, especially if the expected usage
>    is to use per-context singleton loader.  For example, both b10-auth
>    and b10-resolver would use the RequestContext, but the reasonable
>    default action would (or might) be different: for auth, "default
>    accept" probably makes most sense, while "default reject" would be
>    most reasonable for the resolver.  But we cannot customize the
>    default as long as we use the singleton loader (and not using it
>    would be inconvenient because the application would have to
>    register default creators).  Instead, I'd suggest we specify the
>    default action via the load() method (and if it's deemed to be
>    reasonable, we can specify the default value).

It sounds reasonable. I thought the reject would be default in all of them, but
having accept as default in auth is probably what we want.

The question is, do we want to create a ticket for these cleanups? And if so, do
we wait for next sprint?

I also discovered one thing that got omitted, and it is registering the ALL and
ANY operators in the loader.

With regards

-- 
Anyone seen smoking will be considered on fire and will be put out immediately.

Michal 'vorner' Vaner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <https://lists.isc.org/pipermail/bind10-dev/attachments/20110701/b3465edf/attachment.bin>