[bind10-dev] a couple of small things about ACL loader

[JINMEI Tatuya / 神明達哉]

At Fri, 1 Jul 2011 11:51:17 +0200,
Michal 'vorner' Vaner <michal.vaner at nic.cz> wrote:

> > 1. why is CheckCreator::create() not a const member function?
> >    Existing examples don't seem to need to modify the class, and
> >    considering its nature (essentially it works as a factory), I
> >    suspect it can naturally be a const member function.
> 
> I probably just overlooked it when writing it. It can safely be constified.
> 
> > 2. I'm afraid it's too restrictive to specify the default action
[...]
> >    register default creators).  Instead, I'd suggest we specify the
> >    default action via the load() method (and if it's deemed to be
> >    reasonable, we can specify the default value).
> 
> It sounds reasonable. I thought the reject would be default in all
> of them, but having accept as default in auth is probably what we
> want.
> 
> The question is, do we want to create a ticket for these cleanups?
> And if so, do we wait for next sprint?

I don't have a strong opinion, but these are minor but not super
trivial, and wouldn't affect existing code much (constify won't have
any effect, and if we use the default parameter for default action,
the second change won't affect apps either), I think it should be done
in a separate cleanup ticket (I guess one is enough for both), and it
can wait until the next sprint.

---
JINMEI, Tatuya
Internet Systems Consortium, Inc.