[bind10-dev] minor problems on the existing BIND10 review procedure

Jeremy C. Reed jreed at isc.org
Mon Dec 10 18:30:26 UTC 2012


Reviewing http://bind10.isc.org/wiki/CodeReviewProcedure
as part of ISC Engineering Best Practices board work.
(bottom says Review scheduled 2010-12-18)

Tickets are not created specifically for a "review".

Ticket titles do not say "review" in them.

The method of indicating (not "announced") is setting the ticket to 
review state that is unowned. No announcement is sent to list nor to 
manager.

make distcheck is only correct to run tests if --with-gtest is used 
(also maybe misleading since this doesn't do the system level checks).

Usually the checklist is not copy-and-pasted in response(s).




More information about the bind10-dev mailing list