[bind10-dev] minor problems on the existing BIND10 review procedure

[Michal 'vorner' Vaner]

Hello

On Mon, Dec 10, 2012 at 12:30:26PM -0600, Jeremy C. Reed wrote:
> Reviewing http://bind10.isc.org/wiki/CodeReviewProcedure
> as part of ISC Engineering Best Practices board work.
> (bottom says Review scheduled 2010-12-18)
> 
> Tickets are not created specifically for a "review".
> 
> Ticket titles do not say "review" in them.
> 
> The method of indicating (not "announced") is setting the ticket to 
> review state that is unowned. No announcement is sent to list nor to 
> manager.
> 
> make distcheck is only correct to run tests if --with-gtest is used 
> (also maybe misleading since this doesn't do the system level checks).
> 
> Usually the checklist is not copy-and-pasted in response(s).

If the difference between practice and the page is a problem, I'm for updating
the page, not our current practices. I think the practices work and we got there
by natural development of the review process.

With regards

-- 
I never finish anyth

Michal 'vorner' Vaner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <https://lists.isc.org/pipermail/bind10-dev/attachments/20121211/b9a5f46c/attachment.bin>