[bind10-dev] Call for topics for team call on 2012-02-01
Francis Dupont
fdupont at isc.org
Wed Feb 1 09:28:09 UTC 2012
> - C++ header file inclusion order
> As usual(?) we have inconsistent styles in our code:
> - include standard and external library headers first:
> <string> <boost/shared_ptr.hpp> <dns/message.h>
> - include standard and external library headers first:
> <dns/message.h> <boost/shared_ptr.hpp> <string>
>
> Note that in some cases we need to include specific header file very
> first. Python.h is one such example. (and I in fact had a trouble if
> I didn't put it first).
>
> Mostly a bikeshed matter, but as a consistency lover I want to have
> consistent style if we can agree.
=> I join you about this point and I add when config.h is included
(and IMHO it should be included in almost all files) it must be
the first one.
BTW some platforms are sensible about the include order, for instance
Windows (I know Windows is not in the priority but as Windows has still
90% of the market we can be unhappy, etc, but we can't ignore it...).
Thanks
Francis Dupont <fdupont at isc.org>
PS: I prefer the first i.e.:
include standard and external library headers first:
<string> <boost/shared_ptr.hpp> <dns/message.h>
(with <config.h> in head of course)
More information about the bind10-dev
mailing list