[bind10-dev] Call for topics for team call on 2012-02-01

[JINMEI Tatuya / 神明達哉]

At Wed, 01 Feb 2012 09:28:09 +0000,
Francis Dupont <fdupont at isc.org> wrote:
> 
> > - C++ header file inclusion order
> >   As usual(?) we have inconsistent styles in our code:
> >   - include standard and external library headers first:
> >     <string> <boost/shared_ptr.hpp> <dns/message.h>
> >   - include standard and external library headers first:
(oops, there was a typo here, I meant "last")
> >     <dns/message.h> <boost/shared_ptr.hpp> <string>

> => I join you about this point and I add when config.h is included
> (and IMHO it should be included in almost all files) it must be
> the first one.
> BTW some platforms are sensible about the include order, for instance
> Windows (I know Windows is not in the priority but as Windows has still
> 90% of the market we can be unhappy, etc, but we can't ignore it...).
> 
> Thanks
> 
> Francis Dupont <fdupont at isc.org>
> 
> PS: I prefer the first i.e.:
>     include standard and external library headers first:
>     <string> <boost/shared_ptr.hpp> <dns/message.h>
>     (with <config.h> in head of course)

FYI: according to today's biweekly call we decided to switch to the
opposite style:
     <dns/message.h> <boost/shared_ptr.hpp> <string>

Exceptions apply (Python.h, config.h), of course.

---
JINMEI, Tatuya