[bind10-dev] BIND 10 trac1958, updated. 7017538fe54478e47fe1bdda055d3545a5d70f66 [1958] Instrumentation to monitor unordered packet lookups.

[JINMEI Tatuya / 神明達哉]

Just happened to notice this...

At Thu, 12 Jul 2012 07:34:51 +0000,
BIND 10 source code commits <bind10-changes at lists.isc.org> wrote:

> +        /// \brief Add new packet to list of received packets.
> +        ///
> +        /// Method adds new packet to list of received packets.
> +        ///
> +        /// \param packet packet object to be added.
> +        void appendRcvd(const boost::shared_ptr<T> packet) {
> +            rcvd_packets_.template get<0>().push_back(packet);
> +        }

I guess the type of 'packet' is not what was actually intended; if
it's intended to be a shared_ptr version of 'const T* packet', it
should be 'boost::shared_ptr<const T> packet'.  ('const
boost::shared_ptr<T> packet' is a shared_ptr version of 'T* const
packet')

---
JINMEI, Tatuya