[bind10-dev] failed unittests

[JINMEI Tatuya / 神明達哉]

At Wed, 23 May 2012 04:00:02 GMT,
BIND 10 Tests <tester at isc.org> wrote:

> http://git.bind10.isc.org/~tester/builder//BIND10-cppcheck/20120523033006-FreeBSD8-amd64-GCC/logs/unittests.out
> 
> http://git.bind10.isc.org/~tester/builder//builder.html

This seems to be the exact issue we discussed today (or yesterday,
for most of you): test executable refers to an older version of BIND
10 library under /usr/local/lib.

That's because we specify $(GTEST_LDADD) (and in some case
$(SQLITE_LIBS)) at the top of LDADD list, and libtool place
/usr/local/bin at the first:

    # Add our own library path to LD_LIBRARY_PATH
    LD_LIBRARY_PATH="/usr/local/lib:/usr/home/jinmei/src/isc/git/bind10/src/lib/asiolink/.libs:/usr/home/jinmei/src/isc/git/bind10/src/lib/log/.libs:/usr/home/jinmei/src/isc/git/bind10/src/lib/util/.libs:/usr/home/jinmei/src/isc/git/bind10/src/lib/util/io/.libs:/usr/home/jinmei/src/isc/git/bind10/src/lib/exceptions/.libs:$LD_LIBRARY_PATH"

So, the patch pasted below solves the problem on this particular
platform.  I'm not sure if this is a generally applicable solution or
can be safely applied without breaking others, though.

Should we apply this?

---
JINMEI, Tatuya

diff --git a/src/bin/auth/tests/Makefile.am b/src/bin/auth/tests/Makefile.am
index 3a7c54b..4b6621e 100644
--- a/src/bin/auth/tests/Makefile.am
+++ b/src/bin/auth/tests/Makefile.am
@@ -54,9 +54,7 @@ nodist_run_unittests_SOURCES = ../auth_messages.h ../auth_messages.cc
 
 run_unittests_CPPFLAGS = $(AM_CPPFLAGS) $(GTEST_INCLUDES)
 run_unittests_LDFLAGS = $(AM_LDFLAGS) $(GTEST_LDFLAGS)
-run_unittests_LDADD = $(GTEST_LDADD)
-run_unittests_LDADD += $(SQLITE_LIBS)
-run_unittests_LDADD += $(top_builddir)/src/lib/testutils/libtestutils.la
+run_unittests_LDADD = $(top_builddir)/src/lib/testutils/libtestutils.la
 run_unittests_LDADD +=  $(top_builddir)/src/lib/datasrc/libdatasrc.la
 run_unittests_LDADD +=  $(top_builddir)/src/lib/dns/libdns++.la
 run_unittests_LDADD += $(top_builddir)/src/lib/util/libutil.la
@@ -71,6 +69,8 @@ run_unittests_LDADD += $(top_builddir)/src/lib/server_common/libserver_common.la
 run_unittests_LDADD += $(top_builddir)/src/lib/nsas/libnsas.la
 run_unittests_LDADD += $(top_builddir)/src/lib/util/unittests/libutil_unittests.la
 run_unittests_LDADD += $(top_builddir)/src/lib/statistics/libstatistics.la
+run_unittests_LDADD += $(GTEST_LDADD)
+run_unittests_LDADD += $(SQLITE_LIBS)
 
 check-local:
 	B10_FROM_BUILD=${abs_top_builddir} ./run_unittests
diff --git a/src/lib/asiolink/tests/Makefile.am b/src/lib/asiolink/tests/Makefile.am
index 984cf07..eaa2173 100644
--- a/src/lib/asiolink/tests/Makefile.am
+++ b/src/lib/asiolink/tests/Makefile.am
@@ -33,11 +33,11 @@ run_unittests_SOURCES += udp_socket_unittest.cc
 
 run_unittests_CPPFLAGS = $(AM_CPPFLAGS) $(GTEST_INCLUDES)
 
-run_unittests_LDADD  = $(GTEST_LDADD)
-run_unittests_LDADD += $(top_builddir)/src/lib/asiolink/libasiolink.la
+run_unittests_LDADD = $(top_builddir)/src/lib/asiolink/libasiolink.la
 run_unittests_LDADD += $(top_builddir)/src/lib/log/liblog.la
 run_unittests_LDADD += $(top_builddir)/src/lib/util/unittests/libutil_unittests.la
 run_unittests_LDADD += $(top_builddir)/src/lib/exceptions/libexceptions.la
+run_unittests_LDADD += $(GTEST_LDADD)
 
 run_unittests_LDFLAGS = $(AM_LDFLAGS) $(GTEST_LDFLAGS)
 
diff --git a/src/lib/util/tests/Makefile.am b/src/lib/util/tests/Makefile.am
index 4aea951..c4d7381 100644
--- a/src/lib/util/tests/Makefile.am
+++ b/src/lib/util/tests/Makefile.am
@@ -39,12 +39,13 @@ run_unittests_SOURCES += range_utilities_unittest.cc
 run_unittests_CPPFLAGS = $(AM_CPPFLAGS) $(GTEST_INCLUDES)
 run_unittests_LDFLAGS = $(AM_LDFLAGS) $(GTEST_LDFLAGS)
 
-run_unittests_LDADD  = $(GTEST_LDADD)
-run_unittests_LDADD += $(top_builddir)/src/lib/util/libutil.la
+#run_unittests_LDADD  = $(GTEST_LDADD)
+run_unittests_LDADD = $(top_builddir)/src/lib/util/libutil.la
 run_unittests_LDADD += $(top_builddir)/src/lib/util/io/libutil_io.la
 run_unittests_LDADD += \
 	$(top_builddir)/src/lib/util/unittests/libutil_unittests.la
 run_unittests_LDADD += $(top_builddir)/src/lib/exceptions/libexceptions.la
+run_unittests_LDADD += $(GTEST_LDADD)
 endif
 
 noinst_PROGRAMS = $(TESTS)