[bind10-dev] Minor things about the master loader

[Michal 'vorner' Vaner]

Hello

I have two questions about the currently being developed master loader.
 • Should we move it to a separate sub-namespace and directory
   (isc::dns::master_load)? There seems to be some number of classes already.
   Also, the proposals seem to suggest there's a need for one ‒ for example
   #2376 suggests the struct Callbacks be part of dns::MasterLoader. But it
   could also be part of something else, like MasterLoaderContextBase. So I
   think we should put them on the same level (or all part of MasterLoader).
 • The InputSource provides line number only. But the API design suggests we
   should pass line number and byte offset in the file with errors and warnings.
   Should the master loader/lexer/whatever count the bytes as it calls
   inputSource.getChar() or should this function be added to the input source?

With regards

-- 
When a fly lands on the ceiling, does it do a half roll or a half loop?

Michal 'vorner' Vaner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <https://lists.isc.org/pipermail/bind10-dev/attachments/20121105/824f81b7/attachment.bin>