[bind10-dev] Use of -Werror in release tarballs

[Jeremy C. Reed]

On Wed, 20 Feb 2013, Mukund Sivaraman wrote:

> It will affect whether we ship BIND 10 stable releases with the flag 
> included or not.

Is this what you are proposing for the release?

diff --git a/configure.ac b/configure.ac
index 5195c24..a7214bd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -143,14 +143,14 @@ esac
 
 # Don't use -Werror if configured not to
 AC_ARG_WITH(werror,
-    AC_HELP_STRING([--with-werror], [Compile using -Werror 
(default=yes)]),
+    AC_HELP_STRING([--with-werror], [Compile using -Werror 
(default=no)]),
     [
      case "${withval}" in
          yes) with_werror=1 ;;
          no)  with_werror=0 ;;
          *)   AC_MSG_ERROR(bad value ${withval} for --with-werror) ;;
      esac],
-     [with_werror=1])
+     [with_werror=0])
 
 werror_ok=0

Would an acceptable alternative be to document to use --without-werror 
if encountering a compiler warning resulting an error? Something like:

diff --git a/doc/guide/bind10-guide.xml b/doc/guide/bind10-guide.xml
index cea70c2..56b308d 100644
--- a/doc/guide/bind10-guide.xml
+++ b/doc/guide/bind10-guide.xml
@@ -772,6 +772,16 @@ as a dependency earlier -->
             </listitem>
           </varlistentry>
 
+          <varlistentry>
+            <term>--without-werror</term>
+            <listitem>
+              <simpara>Disable the default use of the
+		<option>-Werror</option> compiler flag so that
+		compiler warnings aren't build failures.
+              </simpara>
+            </listitem>
+          </varlistentry>
+
           </variablelist>
           <note>
             <para>

(Please suggest better or further wording.)

I looked for guidelines or policies for this topic for Debian and other 
packaging systems, but couldn't find it. Any pointers? The pkgsrc 
community had a discussion about this starting at 
http://mail-index.netbsd.org/tech-pkg/2012/10/13/msg010186.html but I 
think the consensus didn't agree with this initial proposal. (The 
context there is that the same package build system is used for multiple 
operating systems with different compilers, different build 
environments, different system headers.)