BIND 10 #423: simple master file loader

BIND 10 Development do-not-reply at isc.org
Wed Dec 15 07:40:39 UTC 2010


#423: simple master file loader
--------------------------------+-------------------------------------------
      Reporter:  jinmei         |        Owner:  jinmei               
          Type:  task           |       Status:  reviewing            
      Priority:  major          |    Milestone:  y2 12 month milestone
     Component:  DNSPacket API  |   Resolution:                       
      Keywords:                 |    Sensitive:  0                    
Estimatedhours:  0.0            |        Hours:  0                    
      Billable:  1              |   Totalhours:  0                    
      Internal:  0              |  
--------------------------------+-------------------------------------------
Changes (by zzchen_pku):

  * owner:  zzchen_pku => jinmei


Comment:

 Seems ok, some comments below:
 '''master.h'''
 -Exception name 'MasterError' is ambiguous, since the exception is related
 to master file loading.
 -We have discussed on boost dependency for a long time:-) In my personal
 opinion,  because boost.function has been introduced into std::fr1, and it
 is a general interface, we don't have to add a supplemental class to
 replace it, which will reduce the readability of our code.
 '''master.c'''
 -It seems the variable 'prev_rrset' can be replaced by 'rrset'.

-- 
Ticket URL: <http://bind10.isc.org/ticket/423#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list