BIND 10 #423: simple master file loader

[BIND 10 Development]

#423: simple master file loader
--------------------------------+-------------------------------------------
      Reporter:  jinmei         |        Owner:  zzchen_pku           
          Type:  task           |       Status:  reviewing            
      Priority:  major          |    Milestone:  y2 12 month milestone
     Component:  DNSPacket API  |   Resolution:                       
      Keywords:                 |    Sensitive:  0                    
Estimatedhours:  0.0            |        Hours:  0                    
      Billable:  1              |   Totalhours:  0                    
      Internal:  0              |  
--------------------------------+-------------------------------------------
Changes (by jinmei):

  * owner:  jinmei => zzchen_pku


Comment:

 Replying to [comment:4 zzchen_pku]:
 > Seems ok, some comments below:
 > '''master.h'''
 > -Exception name 'MasterError' is ambiguous, since the exception is
 related to master file loading.
 >
 Hmm maybe we should rename it !MasterLoadError?  In that case I'd also
 rename file names from master.xx to masterload.xx.

 > -We have discussed on boost dependency for a long time:-) In my personal
 opinion,  because boost.function has been introduced into std::fr1, and it
 is a general interface, we don't have to add a supplemental class to
 replace it, which will reduce the readability of our code.
 >
 I think we have to agree to disagree here, but for this branch I adopted
 your preference and changed the definition using boost.function.

 It's not about the spec is standardized or not.  It's about maturity of
 implementation, especially in terms of binary compatibility.  But this is
 a more general topic, and I guess we (all developers) should discuss this
 in f2f in January.

 > '''master.c'''
 > -It seems the variable 'prev_rrset' can be replaced by 'rrset'.
 >
 Ah, good catch.  Fixed.

-- 
Ticket URL: <http://bind10.isc.org/ticket/423#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development