BIND 10 #436: review: bind10.isc (debian) requires libboost_thread

[BIND 10 Development]

#436: review: bind10.isc (debian) requires libboost_thread
-------------------------------+--------------------------------------------
      Reporter:  jinmei        |        Owner:  UnAssigned           
          Type:  defect        |       Status:  reviewing            
      Priority:  critical      |    Milestone:  y2 12 month milestone
     Component:  build system  |   Resolution:                       
      Keywords:                |    Sensitive:  0                    
Estimatedhours:  0.0           |        Hours:  0                    
      Billable:  1             |   Totalhours:  0                    
      Internal:  0             |  
-------------------------------+--------------------------------------------

Comment(by jelte):

 Have not tested it, but do have a few comments

 I'd prefer if the indentation followed other guidelines (the without/with
 checks appear to be serial on first glance, while the with is only done if
 the without fails).

 Also, i'd prefer if the final error is a bit more clear;
 {{{
 Perhaps you are using an older version of Boost that requires
 libboost_thread for the mutex support. You may want to check
 the availability of the library or to upgrade Boost.
 }}}
 to
 {{{
 Perhaps you are using an older version of Boost that requires
 libboost_thread for the mutex support, which does not appear
 to be available. You may want to check the availability of
 the library or to upgrade Boost.
 }}}
 (Don't know how much better this is, but initially I though that we
 errored on requiring libboost_thread in the first place, not on needing it
 but not finding it)

 Thirdly, I hope we are planning on getting rid of that indirect dependency
 (can we?), in which case it might be prudent to add a little comment in
 both additions to remove the other one if it is removed itself (and
 perhaps the other two comments can be ignored in that case) :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/436#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development