BIND 10 #436: review: bind10.isc (debian) requires libboost_thread

[BIND 10 Development]

#436: review: bind10.isc (debian) requires libboost_thread
-------------------------------+--------------------------------------------
      Reporter:  jinmei        |        Owner:  jelte                
          Type:  defect        |       Status:  reviewing            
      Priority:  critical      |    Milestone:  y2 12 month milestone
     Component:  build system  |   Resolution:                       
      Keywords:                |    Sensitive:  0                    
Estimatedhours:  0.0           |        Hours:  0                    
      Billable:  1             |   Totalhours:  0                    
      Internal:  0             |  
-------------------------------+--------------------------------------------
Changes (by jinmei):

  * owner:  UnAssigned => jelte


Comment:

 Replying to [comment:3 jelte]:
 > Have not tested it, but do have a few comments
 >
 > I'd prefer if the indentation followed other guidelines (the
 without/with checks appear to be serial on first glance, while the with is
 only done if the without fails).
 >
 Do you mean something like this?

 {{{
         [ AC_MSG_RESULT(yes (without libboost_thread)) ],
         [ LIBS=" $LIBS -lboost_thread"
           AC_TRY_LINK([
 #include <boost/thread.hpp>
 ],[
 boost::mutex m;
 ],
                   [ AC_MSG_RESULT(yes (with libboost_thread))
                     need_libboost_thread=1 ],
                   [ AC_MSG_RESULT(no)
                     AC_MSG_ERROR([boost::mutex cannot be linked in this
 build environment.
 ...
 }}}

 > Also, i'd prefer if the final error is a bit more clear;
 >
 I have no preference on this.  I'll simply use your suggested text.

 > Thirdly, I hope we are planning on getting rid of that indirect
 dependency (can we?), in which case it might be prudent to add a little
 comment in both additions to remove the other one if it is removed itself
 (and perhaps the other two comments can be ignored in that case) :)
 >
 What do you mean by "indirect dependency"?  Dependency on libboost_thread
 for boost::mutex (in older boost)?  If so, you mean by requiring newer
 versions of boost?  That can be an option, although I think we should
 discuss it separately (it's a tradeoff between simpler source and lowering
 the introduction bar).  I have no problem in adding comments to this hack
 per se.

-- 
Ticket URL: <http://bind10.isc.org/ticket/436#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development