BIND 10 #436: review: bind10.isc (debian) requires libboost_thread

[BIND 10 Development]

#436: review: bind10.isc (debian) requires libboost_thread
-------------------------------+--------------------------------------------
      Reporter:  jinmei        |        Owner:  jelte                
          Type:  defect        |       Status:  reviewing            
      Priority:  critical      |    Milestone:  y2 12 month milestone
     Component:  build system  |   Resolution:                       
      Keywords:                |    Sensitive:  0                    
Estimatedhours:  0.0           |        Hours:  0                    
      Billable:  1             |   Totalhours:  0                    
      Internal:  0             |  
-------------------------------+--------------------------------------------

Comment(by jelte):

 Replying to [comment:4 jinmei]:
 > >
 > Do you mean something like this?
 >
 > {{{
 >       [ AC_MSG_RESULT(yes (without libboost_thread)) ],
 >       [ LIBS=" $LIBS -lboost_thread"
 >         AC_TRY_LINK([
 > #include <boost/thread.hpp>
 > ],[
 > boost::mutex m;
 > ],
 >                 [ AC_MSG_RESULT(yes (with libboost_thread))
 >                   need_libboost_thread=1 ],
 >                 [ AC_MSG_RESULT(no)
 >                   AC_MSG_ERROR([boost::mutex cannot be linked in this
 build environment.
 > ...
 > }}}
 >

 Yes, that makes it much more clear to me that the second try is because
 the first failed.

 >
 > > Thirdly, I hope we are planning on getting rid of that indirect
 dependency (can we?), in which case it might be prudent to add a little
 comment in both additions to remove the other one if it is removed itself
 (and perhaps the other two comments can be ignored in that case) :)
 > >
 > What do you mean by "indirect dependency"?  Dependency on
 libboost_thread for boost::mutex (in older boost)?  If so, you mean by
 requiring newer versions of boost?  That can be an option, although I
 think we should discuss it separately (it's a tradeoff between simpler
 source and lowering the introduction bar).  I have no problem in adding
 comments to this hack per se.

 yeah, i meant depending on things we don't use ourselves because classes
 we do depend on them, that newer version don't seem to have that makes the
 choice a bit harder, since it looks like the problem will go away
 eventually, but indeed that would require suggesting to use a newer
 version. (btw i don't have much problems requiring a somewhat newer
 version at this point, but indeed that is a different discussion)

 so ack, commit :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/436#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development