BIND 10 #422: Implement memory Data Source Class

BIND 10 Development do-not-reply at isc.org
Wed Dec 15 22:58:39 UTC 2010


#422: Implement memory Data Source Class
------------------------------+---------------------------------------------
      Reporter:  zzchen_pku   |        Owner:  zzchen_pku
          Type:  task         |       Status:  reviewing 
      Priority:  major        |    Milestone:            
     Component:  data source  |   Resolution:            
      Keywords:               |    Sensitive:  0         
Estimatedhours:  0.0          |        Hours:  0         
      Billable:  1            |   Totalhours:  0         
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by jinmei):

  * owner:  jinmei => zzchen_pku


Comment:

 Replying to [comment:7 zzchen_pku]:
 > Committed in r3847, please go ahead:-)

 I made some editorial suggestions in r3850.  Please check.

 One final thing: we can omit "isc::datasrc::" within that particular
 namespace or after 'using namespace isc::datasrc', so, for example, this
 one
 {{{
 isc::datasrc::result::Result
 MemoryDataSrc::addZone(ZonePtr zone) {
 }}}
 can be this:
 {{{
 result::Result
 MemoryDataSrc::addZone(ZonePtr zone) {
 }}}

 Different developers seem to have different opinions on how much specific
 we can/should be about namespace specification, so you were intentionally
 redundant.  I personally think it makes sense to keep things concise (e.g.
 by avoiding too long lines) when they can safely be so, and being specific
 while doing 'using namespace xxx' doesn't make much sense anyway, so I'd
 suggest the latter way.  But you did it intentionally with a strong
 preference I wouldn't insist on my preference.  (maybe we should discuss
 this at project-wide in January)

-- 
Ticket URL: <http://bind10.isc.org/ticket/422#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list