BIND 10 #422: Implement memory Data Source Class
BIND 10 Development
do-not-reply at isc.org
Thu Dec 16 03:19:28 UTC 2010
#422: Implement memory Data Source Class
------------------------------+---------------------------------------------
Reporter: zzchen_pku | Owner: jinmei
Type: task | Status: reviewing
Priority: major | Milestone:
Component: data source | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 0.0 | Hours: 0
Billable: 1 | Totalhours: 0
Internal: 0 |
------------------------------+---------------------------------------------
Changes (by zzchen_pku):
* owner: zzchen_pku => jinmei
Comment:
Replying to [comment:8 jinmei]:
> I made some editorial suggestions in r3850. Please check.
Thank you.
> One final thing: we can omit "isc::datasrc::" within that particular
namespace or after 'using namespace isc::datasrc', so, for example, this
one
> {{{
> isc::datasrc::result::Result
> MemoryDataSrc::addZone(ZonePtr zone) {
> }}}
> can be this:
> {{{
> result::Result
> MemoryDataSrc::addZone(ZonePtr zone) {
> }}}
>
> Different developers seem to have different opinions on how much
specific we can/should be about namespace specification, so you were
intentionally redundant. I personally think it makes sense to keep things
concise (e.g. by avoiding too long lines) when they can safely be so, and
being specific while doing 'using namespace xxx' doesn't make much sense
anyway, so I'd suggest the latter way. But you did it intentionally with
a strong preference I wouldn't insist on my preference. (maybe we should
discuss this at project-wide in January)
That's ok for me, we should make code more concise. I have updated the
code in r3853, please check.
--
Ticket URL: <http://bind10.isc.org/ticket/422#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list