BIND 10 #273: passing NULL to non-pointer argument 3 for some unit tests

[BIND 10 Development]

#273: passing NULL to non-pointer argument 3 for some unit tests
--------------------------+-------------------------------------------------
 Reporter:  jreed         |       Owner:     
     Type:  defect        |      Status:  new
 Priority:  major         |   Milestone:     
Component:  Unclassified  |    Keywords:     
Sensitive:  0             |  
--------------------------+-------------------------------------------------
 #192 caused build failures on my NetBSD with g++ (GCC) 4.1.3

 {{{
 g++ -DHAVE_CONFIG_H -I. -I../../../../../src/lib/datasrc/tests
 -I../../../..  -I../../../../../src/lib -I../../../../src/lib
 -I../../../../src/lib/dns -I../../../../../src/lib/dns
 -DTEST_DATA_DIR=\"../../../../../src/lib/datasrc/tests/testdata\"
 -I/usr/pkg/include -I/usr/pkg/include -I../../../../../ext/asio
 -DASIO_DISABLE_KQUEUE=1 -Wall -Wextra -Wwrite-strings -Woverloaded-virtual
 -Wno-sign-compare -Werror -fPIC -g -MT run_unittests-datasrc_unittest.o
 -MD -MP -MF .deps/run_unittests-datasrc_unittest.Tpo -c -o run_unittests-
 datasrc_unittest.o `test -f 'datasrc_unittest.cc' || echo
 '../../../../../src/lib/datasrc/tests/'`datasrc_unittest.cc
 cc1plus: warnings being treated as errors
 ../../../../../src/lib/datasrc/tests/datasrc_unittest.cc: In member
 function 'virtual
 void<unnamed>::DataSrcMatchTest_matchWithWrongClass_Test::TestBody()':
 ../../../../../src/lib/datasrc/tests/datasrc_unittest.cc:991: warning:
 passing NULL to non-pointer argument 3 of 'static testing::AssertionResult
 testing::internal::EqHelper<true>::Compare(const char*, const char*, const
 T1&, T2*) [with T1 = long int, T2 = const isc::dns::Name]'
 ../../../../../src/lib/datasrc/tests/datasrc_unittest.cc:992: warning:
 passing NULL to non-pointer argument 3 of 'static testing::AssertionResult
 testing::internal::EqHelper<true>::Compare(const char*, const char*, const
 T1&, T2*) [with T1 = long int, T2 = const isc::datasrc::DataSrc]'
 ../../../../../src/lib/datasrc/tests/datasrc_unittest.cc: In member
 function 'virtual
 void<unnamed>::DataSrcMatchTest_updateWithWrongClass_Test::TestBody()':
 ../../../../../src/lib/datasrc/tests/datasrc_unittest.cc:1007: warning:
 passing NULL to non-pointer argument 3 of 'static testing::AssertionResult
 testing::internal::EqHelper<true>::Compare(const char*, const char*, const
 T1&, T2*) [with T1 = long int, T2 = const isc::dns::Name]'
 ../../../../../src/lib/datasrc/tests/datasrc_unittest.cc:1008: warning:
 passing NULL to non-pointer argument 3 of 'static testing::AssertionResult
 testing::internal::EqHelper<true>::Compare(const char*, const char*, const
 T1&, T2*) [with T1 = long int, T2 = const isc::datasrc::DataSrc]'
 ../../../../../src/lib/datasrc/tests/datasrc_unittest.cc:1012: warning:
 passing NULL to non-pointer argument 3 of 'static testing::AssertionResult
 testing::internal::EqHelper<true>::Compare(const char*, const char*, const
 T1&, T2*) [with T1 = long int, T2 = const isc::dns::Name]'
 ../../../../../src/lib/datasrc/tests/datasrc_unittest.cc:1013: warning:
 passing NULL to non-pointer argument 3 of 'static testing::AssertionResult
 testing::internal::EqHelper<true>::Compare(const char*, const char*, const
 T1&, T2*) [with T1 = long int, T2 = const isc::datasrc::DataSrc]'
 ../../../../../src/lib/datasrc/tests/datasrc_unittest.cc: In member
 function 'virtual
 void<unnamed>::DataSrcMatchTest_initialUpdateWithNoMatch_Test::TestBody()':
 ../../../../../src/lib/datasrc/tests/datasrc_unittest.cc:1049: warning:
 passing NULL to non-pointer argument 3 of 'static testing::AssertionResult
 testing::internal::EqHelper<true>::Compare(const char*, const char*, const
 T1&, T2*) [with T1 = long int, T2 = const isc::dns::Name]'
 ../../../../../src/lib/datasrc/tests/datasrc_unittest.cc:1050: warning:
 passing NULL to non-pointer argument 3 of 'static testing::AssertionResult
 testing::internal::EqHelper<true>::Compare(const char*, const char*, const
 T1&, T2*) [with T1 = long int, T2 = const isc::datasrc::DataSrc]'
 *** Error code 1
 }}}

 Evan shared some ideas and I patched a few files. (More errors than
 above). Attached is the patch. Please review.

-- 
Ticket URL: <http://bind10.isc.org/ticket/273>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development