BIND 10 #273: passing NULL to non-pointer argument 3 for some unit tests

BIND 10 Development do-not-reply at isc.org
Thu Jul 1 22:20:12 UTC 2010


#273: passing NULL to non-pointer argument 3 for some unit tests
-------------------------+--------------------------------------------------
 Reporter:  jreed        |        Owner:  each                       
     Type:  defect       |       Status:  reviewing                  
 Priority:  major        |    Milestone:  06. 4th Incremental Release
Component:  data source  |   Resolution:                             
 Keywords:               |    Sensitive:  0                          
-------------------------+--------------------------------------------------
Changes (by jinmei):

  * owner:  => each
  * status:  new => reviewing
  * component:  Unclassified => data source
  * milestone:  => 06. 4th Incremental Release


Comment:

 Replying to [ticket:273 jreed]:

 > Evan shared some ideas and I patched a few files. (More errors than
 above). Attached is the patch. Please review.

 I don't think replacing EXPECT_EQ with EXPECT_{TRUE,FALSE} is a good idea
 because the latter is less informative on failure.  Besides, regarding a
 pointer value as boolean is itself not a good practice.

 Actually, we already encoutered this problem and fixed in a cleaner way,
 but somehow it seemed to be reverted (e.g. in r2383).  We should revive
 them, and apply the same sense of change to other cases.

 Giving it back to Evan.

-- 
Ticket URL: <http://bind10.isc.org/ticket/273#comment:1>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list