BIND 10 #167: review: configure addresses and ports to listen on for DNS servers
BIND 10 Development
do-not-reply at isc.org
Thu Jul 1 20:48:36 UTC 2010
#167: review: configure addresses and ports to listen on for DNS servers
----------------------+-----------------------------------------------------
Reporter: larissas | Owner: each
Type: task | Status: reviewing
Priority: major | Milestone: 05. 3rd Incremental Release: Serious Secondary
Component: b10-auth | Resolution:
Keywords: | Sensitive: 0
----------------------+-----------------------------------------------------
Comment(by jinmei):
Commenting on something I just happen to notice:
Replying to [comment:24 shane]:
> This is okay to merge, although I have a question.
>
> The `run_server()` function was changed, but no tests updated. Should we
add a test to insure that an IPv6 address works? Also maybe we should add
a test to check what is thrown if we pass an invalid port number?
(I'm not fully sure what an invalid port number means but) yes, we need
these kinds of tests. I guess we should do this with refactoring the ASIO
link (sub)module. (in trac #221 I've added some network level tests. but
we'll also need whether it works as specified via configuration/comand
line option)
--
Ticket URL: <http://bind10.isc.org/ticket/167#comment:26>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list