BIND 10 #277: cmdctl needs nicer warning if address already in use

BIND 10 Development do-not-reply at isc.org
Fri Jul 16 07:08:37 UTC 2010


#277: cmdctl needs nicer warning if address already in use
--------------------------+-------------------------------------------------
      Reporter:  jreed    |        Owner:  zhanglikun
          Type:  defect   |       Status:  reviewing 
      Priority:  minor    |    Milestone:            
     Component:  cmd-ctl  |   Resolution:            
      Keywords:           |    Sensitive:  0         
Estimatedhours:           |        Hours:            
      Billable:  1        |   Totalhours:            
      Internal:  0        |  
--------------------------+-------------------------------------------------
Changes (by jinmei):

  * owner:  jinmei => zhanglikun


Comment:

 Replying to [comment:5 zhanglikun]:
 > please check r2516 in branch trac277.

  - I'd use CmdctlException instead of exit.  At the very least when we
 encounter an error of this kind, the exit code should be non 0.
  - as a related note, shouldn't we catch CmdctlException in main?  also,
 other cases of raising CmdctlException should be tested (which can go to a
 different ticket though).
  - I'm not sure if this is tested correctly.  doesn't the overridden
 MySecureHTTPServer.server_bind hide the double-bind situation?
  - 8080 might conflict with other existing processes.  in particular, the
 test fails when BIND 10 is currently running on that machine.  So I'd use
 a different port chosen from a safer range.
  - I'd be more specific in the error message than "Error creating
 b10-cmdctl".  in this case it should be clear that the error is a failure
 of creating a server object.

-- 
Ticket URL: <http://bind10.isc.org/ticket/277#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list