BIND 10 #277: cmdctl needs nicer warning if address already in use

[BIND 10 Development]

#277: cmdctl needs nicer warning if address already in use
--------------------------+-------------------------------------------------
      Reporter:  jreed    |        Owner:  zhanglikun
          Type:  defect   |       Status:  reviewing 
      Priority:  minor    |    Milestone:            
     Component:  cmd-ctl  |   Resolution:            
      Keywords:           |    Sensitive:  0         
Estimatedhours:           |        Hours:            
      Billable:  1        |   Totalhours:            
      Internal:  0        |  
--------------------------+-------------------------------------------------

Comment(by zhanglikun):

 Replying to [comment:6 jinmei]:

 >
 >  - I'd use CmdctlException instead of exit.  At the very least when we
 encounter an error of this kind, the exit code should be non 0.

 Yes, the CmdctlException is used now, please check r2521.

 >  - as a related note, shouldn't we catch CmdctlException in main?  also,
 other cases of raising CmdctlException should be tested (which can go to a
 different ticket though).

 Record it in TODO file.

 >  - I'm not sure if this is tested correctly.  doesn't the overridden
 MySecureHTTPServer.server_bind hide the double-bind situation?

 yes, server_bind is overriden, all the communications between fake server
 and client is processed over temp file.

 >  - 8080 might conflict with other existing processes.  in particular,
 the test fails when BIND 10 is currently running on that machine.  So I'd
 use a different port chosen from a safer range.

 If the specified port is used already, by cmdctl or some other process,
 the test case "test_addr_in_use" will be skipped. accept your suggestion,
 selecting one safer port for test.

 >  - I'd be more specific in the error message than "Error creating
 b10-cmdctl".  in this case it should be clear that the error is a failure
 of creating a server object.

 agree. the error message is changed to 'Error creating server'

-- 
Ticket URL: <http://bind10.isc.org/ticket/277#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development