BIND 10 #127: Bindctl: remove client-side certificate && using digest authentication

[BIND 10 Development]

#127: Bindctl: remove client-side certificate && using digest authentication
-------------------------+--------------------------------------------------
 Reporter:  zhanglikun   |        Owner:  jelte                                         
     Type:  enhancement  |       Status:  reviewing                                     
 Priority:  minor        |    Milestone:  05. 3rd Incremental Release: Serious Secondary
Component:  bind-ctl     |   Resolution:                                                
 Keywords:               |    Sensitive:  0                                             
-------------------------+--------------------------------------------------

Comment(by jelte):

 make distcheck fails for me too:
 {{{
 ======================================================================
 ERROR: test_check_config_handler (__main__.TestCommandControl)
 ----------------------------------------------------------------------
 Traceback (most recent call last):
   File
 "/home/jelte/repos/bind10/branches/trac127/bind10-devel-20100602/_build/../src/bin/cmdctl/tests/cmdctl_test.py",
 line 294, in setUp
     self.cmdctl = MyCommandControl(None, True)
   File
 "/home/jelte/repos/bind10/branches/trac127/bind10-devel-20100602/_build/src/bin/cmdctl/cmdctl.py",
 line 214, in __init__
     self._setup_session()
   File
 "/home/jelte/repos/bind10/branches/trac127/bind10-devel-20100602/_build/../src/bin/cmdctl/tests/cmdctl_test.py",
 line 282, in _setup_session
     module_spec =
 isc.config.module_spec_from_file("../cmdctl.spec.pre.in")
   File
 "/home/jelte/repos/bind10/branches/trac127/bind10-devel-20100602/src/lib/python/isc/config/module_spec.py",
 line 45, in module_spec_from_file
     file = open(spec_file)
 IOError: [Errno 2] No such file or directory: '../cmdctl.spec.pre.in'
 }}}

 Changing that hardcoded cmdctl.spec.pre.in to cmdctl.spec fixes it
 (after that i get the same errors as Jeremy)



 bindcmd.py
 111:        Parse commands inputted from user and send them to cmdctl.

 inputted sounds weird, make it simply "parse commands from user and"

 cmdctl.py.in:

 54: you could get that module name from the specfile (or better, through
 the api, i think its moduleccsession.get_module_spec().get_module_name()
 or something similar). That way, should we change it we only have to
 update the spec file :) (its also hardcoded in cfgmgr, we need to find a
 more general solution on that side)

 209: that docstring seems wrong, talks about shutdown in the __init__
 function?

 _setup_session(self): hmz. I think we should consider making msgq/cc so
 that we don't need two sessions, possible 'future work'? :)

 482: that todo seems useful to, eh, do :) you haven't found a method for
 this yet?

 485: i think that socket.error is the wrong exception to raise here (also
 at 489)


 518: shouldn't we use constants for these? (another one on line 530)


 Tests:

 i see a lot of lines like this one:
 {{{
 self.assertTrue(ret == False)
 }}}

 You can also simply use self.assertFalse(ret) :)

 Rest of the changes look good

-- 
Ticket URL: <https://bind10.isc.org/ticket/127#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development