BIND 10 #127: Bindctl: remove client-side certificate && using digest authentication

[BIND 10 Development]

#127: Bindctl: remove client-side certificate && using digest authentication
-------------------------+--------------------------------------------------
 Reporter:  zhanglikun   |        Owner:  jelte                                         
     Type:  enhancement  |       Status:  reviewing                                     
 Priority:  minor        |    Milestone:  05. 3rd Incremental Release: Serious Secondary
Component:  bind-ctl     |   Resolution:                                                
 Keywords:               |    Sensitive:  0                                             
-------------------------+--------------------------------------------------

Comment(by zhanglikun):

 Replying to [comment:13 jelte]:
 >
 > make distcheck fails for me too:
 > > Changing that hardcoded cmdctl.spec.pre.in to cmdctl.spec fixes it
 > (after that i get the same errors as Jeremy)>
 > bindcmd.py
 > 111:        Parse commands inputted from user and send them to cmdctl.>
 > inputted sounds weird, make it simply "parse commands from user and"
 >
 > cmdctl.py.in:>
 > 54: you could get that module name from the specfile (or better, through
 the api, i think its moduleccsession.get_module_spec().get_module_name()
 or something similar). That way, should we change it we only have to
 update the spec file :) (its also hardcoded in cfgmgr, we need to find a
 more general solution on that side)
 >
 > 209: that docstring seems wrong, talks about shutdown in the __init__
 function?
 > >
 > 485: i think that socket.error is the wrong exception to raise here
 (also at 489)
 > >
 > 518: shouldn't we use constants for these? (another one on line 530)
 > >
 > Tests:
 >
 > i see a lot of lines like this one:
 > {{{
 > self.assertTrue(ret == False)
 > }}}
 >
 > You can also simply use self.assertFalse(ret) :)


 All above items have been fixed in r2305, please check.

 >_setup_session(self): hmz. I think we should consider making msgq/cc so
 that we >don't need two sessions, possible 'future work'? :)

 I prefer to two sessions or left it as 'future work', since I want to
 receive the commands from other modules in block mode.(have added it to
 TODO list)

 > 482: that todo seems useful to, eh, do :) you haven't found a method for
 this yet?

 sorry, still haven't, I have added it to TODO list.

-- 
Ticket URL: <http://bind10.isc.org/ticket/127#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development