BIND 10 #168: separate ASIO from Boost and remove custom code

BIND 10 Development do-not-reply at isc.org
Sat May 29 00:43:03 UTC 2010


#168: separate ASIO from Boost and remove custom code
--------------------------+-------------------------------------------------
 Reporter:  larissas      |        Owner:  each                                       
     Type:  task          |       Status:  reviewing                                  
 Priority:  major         |    Milestone:  04. 2nd Incremental Release: Early Adopters
Component:  Unclassified  |   Resolution:                                             
 Keywords:                |    Sensitive:  0                                          
--------------------------+-------------------------------------------------

Comment(by jinmei):

 I made a final minor fix (r1970).

 This branch now seems okay.  Let's merge it to trunk (but see the notes
 below).

 First, now that we *require* asio, autoconf should try to detect its
 existence and fail when that fails.  That could be a separate ticket.

 Second, Jeremy reported a problem with some unit tests in his environment:

 {{{
 static_unittest.cc: In member function 'virtual
 void<unnamed>::StaticDataSourceTest_findClosestEnclosureForVersionClassMismatch_Test::TestBody()':
 static_unittest.cc:217: warning: passing NULL to non-pointer argument 3 of
 'static testing::AssertionResult
 testing::internal::EqHelper<true>::Compare(const char*, const char*, const
 T1&, T2*) [with T1 = long int, T2 = const isc::dns::Name]'
 }}}

 I have no idea why that happened (it compiles fine for me), but if this
 happened for other environments (especially in build bots), we can
 suppress -Werror for the tests directory as a workaround.  So let's
 revisit this after the merge if necessary.

 One more thing: in the ASIO branch, I found this:
 {{{
 +run_unittests_LDADD += -lpthread
 }}}
 in lib/config/tests/Makefile.am

 According to Evan this was necessary in his ubuntu environment.
 "-lpthread" is not always the library name for pthreads, so I'm afraid
 this triggers an error in other systems.  But this is for an optional
 tests directory which can be disabled at build time, so I'm okay with
 revisiting this later (we need to open a seprate ticket for this).

-- 
Ticket URL: <https://bind10.isc.org/ticket/168#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list