BIND 10 #168: separate ASIO from Boost and remove custom code

BIND 10 Development do-not-reply at isc.org
Sat May 29 01:30:01 UTC 2010


#168: separate ASIO from Boost and remove custom code
--------------------------+-------------------------------------------------
 Reporter:  larissas      |        Owner:  each                                       
     Type:  task          |       Status:  reviewing                                  
 Priority:  major         |    Milestone:  04. 2nd Incremental Release: Early Adopters
Component:  Unclassified  |   Resolution:                                             
 Keywords:                |    Sensitive:  0                                          
--------------------------+-------------------------------------------------

Comment(by jinmei):

 Replying to [comment:16 jinmei]:

 > One more thing: in the ASIO branch, I found this:
 > {{{
 > +run_unittests_LDADD += -lpthread
 > }}}
 > in lib/config/tests/Makefile.am
 >
 > According to Evan this was necessary in his ubuntu environment.
 "-lpthread" is not always the library name for pthreads, so I'm afraid
 this triggers an error in other systems.  But this is for an optional
 tests directory which can be disabled at build time, so I'm okay with
 revisiting this later (we need to open a seprate ticket for this).

 Okay, reproduced it on bind10.isc and fixed in r1972.

 We actually didn't need the object definitions for ASIO in "fake"
 sessions: we just need to define a reference to io_service, which is an
 "UNUSED_PARAM".

 So I simply removed them and made sure it compiled on bind10.isc (and on
 my machine).

 I'm still not sure why pthread is necessary here while we aren't not
 required it in other places that actually uses ASIO, though.

 BTW, this is yet another evidence that we should generally avoid including
 external header files (I hope the argument is now getting more and more
 convincing:-)

-- 
Ticket URL: <https://bind10.isc.org/ticket/168#comment:17>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list