BIND 10 #409: cleanup proposal: get rid of UNUSED_PARAM

[BIND 10 Development]

#409: cleanup proposal: get rid of UNUSED_PARAM
-------------------------------+--------------------------------------------
      Reporter:  jinmei        |        Owner:  jinmei              
          Type:  enhancement   |       Status:  reviewing           
      Priority:  minor         |    Milestone:  feature backlog item
     Component:  build system  |   Resolution:                      
      Keywords:                |    Sensitive:  0                   
Estimatedhours:  0.0           |        Hours:  0                   
      Billable:  1             |   Totalhours:  0                   
      Internal:  0             |  
-------------------------------+--------------------------------------------
Changes (by jreed):

  * owner:  jreed => jinmei


Comment:

 Here is a little more below...
 Also what about the comment in src/lib/datasrc/data_source.cc -- does this
 mean the methods should now be defined elsewhere?

 {{{

 Index: src/lib/datasrc/data_source.cc
 ===================================================================
 --- src/lib/datasrc/data_source.cc      (revision 3488)
 +++ src/lib/datasrc/data_source.cc      (working copy)
 @@ -1249,10 +1249,7 @@

  //
  // The following methods are effectively empty, and their parameters are
 -// unused.  To silence compilers that warn unused function parameters,
 -// we specify a (compiler dependent) special keyword when available.
 -// It's defined in config.h, and to avoid including this header file from
 -// installed files we define the methods here.
 +// unused.
  //
  DataSrc::Result
  DataSrc::init(isc::data::ConstElementPtr) {
 Index: src/lib/cc/data.cc
 ===================================================================
 --- src/lib/cc/data.cc  (revision 3488)
 +++ src/lib/cc/data.cc  (working copy)
 @@ -719,7 +719,7 @@
  }

  ElementPtr
 -Element::fromWire(std::stringstream& in, int length) {
 +Element::fromWire(std::stringstream& in, int /* length */ ) {
      //
      // Check protocol version
      //
 Index: src/lib/config/tests/fake_session.h
 ===================================================================
 --- src/lib/config/tests/fake_session.h (revision 3488)
 +++ src/lib/config/tests/fake_session.h (working copy)
 @@ -63,7 +63,7 @@
      virtual int reply(isc::data::ConstElementPtr envelope,
                        isc::data::ConstElementPtr newmsg);
      virtual bool hasQueuedMsgs() const;
 -    virtual void setTimeout(size_t milliseconds) {}
 +    virtual void setTimeout(size_t /* milliseconds */ ) {}
      virtual size_t getTimeout() const { return (0); }
      isc::data::ConstElementPtr getFirstMessage(std::string& group,
                                                 std::string& to) const;
 Index: src/lib/config/tests/Makefile.am
 ===================================================================
 --- src/lib/config/tests/Makefile.am    (revision 3488)
 +++ src/lib/config/tests/Makefile.am    (working copy)
 @@ -4,10 +4,6 @@
  AM_CPPFLAGS += $(BOOST_INCLUDES)

  AM_CXXFLAGS = $(B10_CXXFLAGS)
 -# see src/lib/cc/Makefile.am for -Wno-unused-parameter
 -if USE_GXX
 -AM_CXXFLAGS += -Wno-unused-parameter
 -endif

  if USE_STATIC_LINK
  AM_LDFLAGS = -static
 Index: src/lib/config/tests/fake_session.cc
 ===================================================================
 --- src/lib/config/tests/fake_session.cc        (revision 3488)
 +++ src/lib/config/tests/fake_session.cc        (working copy)
 @@ -91,7 +91,7 @@
  }

  void
 -FakeSession::establish(const char* socket_file) {
 +FakeSession::establish(const char* /* socket_file */ ) {
  }

  bool

 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/409#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development