BIND 10 #409: cleanup proposal: get rid of UNUSED_PARAM

[BIND 10 Development]

#409: cleanup proposal: get rid of UNUSED_PARAM
-------------------------------+--------------------------------------------
      Reporter:  jinmei        |        Owner:  jinmei              
          Type:  enhancement   |       Status:  reviewing           
      Priority:  minor         |    Milestone:  feature backlog item
     Component:  build system  |   Resolution:                      
      Keywords:                |    Sensitive:  0                   
Estimatedhours:  0.0           |        Hours:  0                   
      Billable:  1             |   Totalhours:  0                   
      Internal:  0             |  
-------------------------------+--------------------------------------------

Comment(by jinmei):

 Replying to [comment:3 jreed]:
 > Here is a little more below...
 >
 Ah, nice catch.  Updated in r3490.  Note that we still need the -Wno-
 unused-parameter trick.  It's not for our code, but for ASIO header files.

 > Also what about the comment in src/lib/datasrc/data_source.cc -- does
 this mean the methods should now be defined elsewhere?
 >
 Another good point.  The comment is now completely obsolete, and
 "parameters are unused" is obvious from the code, so I simply removed the
 entire comment.  As for where to define them, they *can* be defined in
 data_source.h now that we don't rely on UNUSED_PARAM, but they don't have
 to be.  Normally, defining a method in a header file is for performance
 reasons (because they are automatically inlined), but these methods
 wouldn't be called in practice, so it's just for a matter of preference.
 For now I'll leave them in .cc.

-- 
Ticket URL: <http://bind10.isc.org/ticket/409#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development