BIND 10 #547: Update of statistics daemon for HTTP/XML reporting: implement
BIND 10 Development
do-not-reply at isc.org
Mon Apr 18 06:08:58 UTC 2011
#547: Update of statistics daemon for HTTP/XML reporting: implement
-------------------------------------+-------------------------------------
Reporter: | Owner: vorner
naokikambe | Status: reviewing
Type: | Milestone:
enhancement | Sprint-20110419
Priority: major | Resolution:
Component: | Sensitive: 0
statistics | Add Hours to Ticket: 0
Keywords: | Total Hours: 0
Estimated Number of Hours: 40.0 |
Billable?: 1 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by naokikambe):
* owner: naokikambe => vorner
Comment:
Sorry for my late response. I completed pushing the all revised codes,
however I added changes which are likely different from your intention.
Please check these codes anyway.
Replying to [comment:8 vorner]:
> * Why does it subscribe to the stats' messages? It does nothing when it
receives such message and it asks for the statistics on demand when they
are needed. I guess nothing would happen if it didn't subscribe to it,
simplifying the code.
Sorry, I couldn't find the corresponding part in the codes as you
mentioned. Could you point it out a bit more exactly again?
Replying to [comment:10 vorner]:
> > > * The get_value seems suspicious. It returns either some spec file
default value or default value of a type. But is it able to return any
actual configured value? Or why isn't it needed?
> > No, it is not able to return any actual value. The purpose of this
get_value is only for getting the default value in the spec file, because
this method is called only when stats_http is loading the spec file at
first. But the behavior of this method is unlike to the behavior of the
original method in the original class. So what about switching the name of
it to `get_default_value`?
>
> OK, seems reasonable.
I couldn't rename the the method, because there isn't the corresponding
method in the original class. (I went through the original class more
properly, I found it didn't correspond to 'get_default_value' in the
original class.) I removed some different parts from the original method,
and added some notes, in stead of renaming the method.
Are these changes okay for you? Please let me know.
Regards,
--
Ticket URL: <https://bind10.isc.org/ticket/547#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list