BIND 10 #547: Update of statistics daemon for HTTP/XML reporting: implement

[BIND 10 Development]

#547: Update of statistics daemon for HTTP/XML reporting: implement
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  naokikambe
  naokikambe                         |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110503
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  statistics                         |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  40.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => naokikambe
 * subproject:   => DNS
 * severity:   => N/A


Comment:

 Good morning

 Replying to [comment:15 naokikambe]:
 > Sorry for my late response. I completed pushing the all revised codes,
 however I added changes which are likely different from your intention.
 Please check these codes anyway.

 They seem mostly OK, with few minor points below.

 > Replying to [comment:8 vorner]:
 > >  * Why does it subscribe to the stats' messages? It does nothing when
 it receives such message and it asks for the statistics on demand when
 they are needed. I guess nothing would happen if it didn't subscribe to
 it, simplifying the code.
 > Sorry, I couldn't find the corresponding part in the codes as you
 mentioned. Could you point it out a bit more exactly again?

 In `open_mccs` and `close_mccs`. It loads STATS specification and
 subscribes to the stats module. But maybe it should read and subscribe to
 the stats-http? Did you test the server in reality, looking at it from
 browser, configuring it, etc? Or, should I do it? This looks strange to
 me, looking at it again, because I don't see any place where it would
 subscribe to it's own module (but maybe I only look at the wrong place
 right now).

 > Replying to [comment:10 vorner]:
 > > OK, seems reasonable.
 > I couldn't rename the the method, because there isn't the corresponding
 method in the original class. (I went through the original class more
 properly, I found it didn't  correspond to 'get_default_value' in the
 original class.) I removed some different parts from the original method,
 and added some notes, in stead of renaming the method.

 OK, I see. That's a mock class and it should have the same method as
 original, right?

 > Are these changes okay for you? Please let me know.

 Only two small things I noticed now:

 With the `open_template` test, you run them in the „successful“ way now.
 But you don't check the result in any way, function that would only open
 the file, but didn't read anything would pass the test the same way this
 does.

 You removed all redirects. My point was, if I type {{{
 http://localhost:8000/some/address }}}, I don't expect the main page. But
 if I type {{{ http://localhost:8000/ }}}, I do. Having a 404 on / is as
 surprising as having the index page on some strange address. Maybe having
 the redirect only when the address is /, but not when it's something
 different? Or provide the page right away in that case?

 I pushed one small comment update.

 With regards.

-- 
Ticket URL: <http://bind10.isc.org/ticket/547#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development