BIND 10 #547: Update of statistics daemon for HTTP/XML reporting: implement
BIND 10 Development
do-not-reply at isc.org
Fri Apr 22 12:33:13 UTC 2011
#547: Update of statistics daemon for HTTP/XML reporting: implement
-------------------------------------+-------------------------------------
Reporter: | Owner: vorner
naokikambe | Status: reviewing
Type: | Milestone:
enhancement | Sprint-20110503
Priority: major | Resolution:
Component: | Sensitive: 0
statistics | Sub-Project: DNS
Keywords: | Estimated Difficulty: 40.0
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by naokikambe):
* owner: naokikambe => vorner
Comment:
Replying to [comment:16 vorner]:
> In `open_mccs` and `close_mccs`. It loads STATS specification and
subscribes to the stats module. But maybe it should read and subscribe to
the stats-http? Did you test the server in reality, looking at it from
browser, configuring it, etc? Or, should I do it? This looks strange to
me, looking at it again, because I don't see any place where it would
subscribe to it's own module (but maybe I only look at the wrong place
right now).
I just missed such the part of the codes. I had removed the part as you
pointed out before. Please see the new code. Of course, I did test in
reality with the web browser.
> That's a mock class and it should have the same method as original,
right?
Yes, that's right.
> With the `open_template` test, you run them in the „successful“ way now.
But you don't check the result in any way, function that would only open
the file, but didn't read anything would pass the test the same way this
does.
I added tests checking internal values.
> You removed all redirects. My point was, if I type {{{
http://localhost:8000/some/address }}}, I don't expect the main page. But
if I type {{{ http://localhost:8000/ }}}, I do. Having a 404 on / is as
surprising as having the index page on some strange address. Maybe having
the redirect only when the address is /, but not when it's something
different? Or provide the page right away in that case?
I reverted the part of the redirection in case of request with '/'.
> I pushed one small comment update.
Thank you very much!
I had already pushed, please see the new codes.
Regards,
--
Ticket URL: <http://bind10.isc.org/ticket/547#comment:17>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list