BIND 10 #404: serialize RDATA for in memory data source

BIND 10 Development do-not-reply at isc.org
Mon Apr 18 10:32:08 UTC 2011


#404: serialize RDATA for in memory data source
-------------------------------------+-------------------------------------
                 Reporter:  jinmei   |                Owner:  jinmei
                     Type:  task     |               Status:  reviewing
                 Priority:  major    |            Milestone:
                Component:  data     |  Sprint-20110419
  source                             |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  0.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Replying to [comment:24 jinmei]:
 > Looks good, but we'll then need getFieldCount() in addition to

 ACK, added.

 > {{{
 > +    virtual const void* getData() const { return
 (getBuffer().getData()); }
 > +    virtual size_t getLength() const { return
 (getBuffer().getLength()); }
 > }}}
 >  (actually shouldn't this be just removed because these methods of
 >  AbstractMessageRenderer aren't virtual?)

 Hmm, yes, I'm just blind.

 > - This one can avoid the use of getBuffer() if we first dump the name
 >   to a local OutputBuffer and copy it using
 >   AbstraceMessageRenderer::writeData().  But that will be a bit more
 >   expensive due to the additional copy, so if you want to avoid this
 >   approach for this reason, I'm okay about it for now.

 I added a TODO note there. We need the getBuffer now because of the
 MessageRenderer anyway, so it can wait until we can actually remove it.

 With regards

-- 
Ticket URL: <https://bind10.isc.org/ticket/404#comment:26>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list