BIND 10 #404: serialize RDATA for in memory data source
BIND 10 Development
do-not-reply at isc.org
Tue Apr 19 18:18:27 UTC 2011
#404: serialize RDATA for in memory data source
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: jinmei
Type: task | Status: reviewing
Priority: major | Milestone:
Component: data | Sprint-20110503
source | Resolution:
Keywords: | Sensitive: 0
Estimated Number of Hours: 0.0 | Add Hours to Ticket: 0
Billable?: 1 | Total Hours: 0
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:26 vorner]:
The latest code looks okay with one minor nit (which is actually not for
the latest diff though):
{{{
unsigned int getFieldSpecDataSize() const { return (nfields_ *
sizeof *fields_); }
}}}
We generally add parentheses after 'sizeof' (following the BIND 9 coding
guideline).
With fixing this please feel free to merge it. Please also feel free
to add your name to the changelog entry if you like.
--
Ticket URL: <http://bind10.isc.org/ticket/404#comment:27>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list