BIND 10 #859: Search cache for lowest reachable delegation

[BIND 10 Development]

#859: Search cache for lowest reachable delegation
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20110503
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  0.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by zhanglikun):

 * owner:  zhanglikun => vorner


Comment:

 Hi vorner, some comments

 1. In line 306, recursive_query.cc
 {{{
    if (!foundAddress && tryName.getLabelCount() > 1) {
 }}}

 We don't need to check "!foundAddress" here, since if it foundAddress is
 true, it has breaked.


 2. in recursive_query_unittest.cc

 If you would like to replace MockResolver with TestResolver(), I suggest
 to remove the definition of MockResolver from the file.


 3. I can't understand what you are trying to test in the following code

 {{{
 926     EXPECT_NO_THROW(EXPECT_EQ(nsUpper->getName(),
 927                               (*resolver_)[0]->getName()) <<
 928                     "It starts resolving at the wrong place") <<
 929         "It does not ask NSAS anything, how does it know where to
 send?";
 }}}

 If you want to test whether resolver has used the lowerest delegation
 point, my opinion is to seperate the code (line 275 to 309,
 recursive_query.cc) to a function with a name
 getLowerestDelegationInCache( too long? ), then add unittest for it.

 others looks ok.

-- 
Ticket URL: <http://bind10.isc.org/ticket/859#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development