BIND 10 #859: Search cache for lowest reachable delegation
BIND 10 Development
do-not-reply at isc.org
Tue Apr 26 19:08:34 UTC 2011
#859: Search cache for lowest reachable delegation
-------------------------------------+-------------------------------------
Reporter: | Owner: zhanglikun
vorner | Status: reviewing
Type: | Milestone:
defect | Sprint-20110503
Priority: major | Resolution:
Component: | Sensitive: 0
Unclassified | Sub-Project: DNS
Keywords: | Estimated Difficulty: 0.0
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => zhanglikun
Comment:
Hello
About the `foundAddress`, actually, it was needed. The break would jump
out of the internal for cycle, containing directly by the if. Anyway,
current version doesn't need it, since there's a return.
The mock class was removed.
I split if off into a separate function (I noticed it's complicated enough
to deserve it's own function anyway, but I named it simply
`deepestDelegation`) and it is tested. But I left the original test there
as well and added a comment that explains the way the test works. Is it OK
now?
Thanks
--
Ticket URL: <http://bind10.isc.org/ticket/859#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list