BIND 10 #1061: introduce DatabaseClient (or DatabaseDataSourceClient)
BIND 10 Development
do-not-reply at isc.org
Tue Aug 9 07:38:08 UTC 2011
#1061: introduce DatabaseClient (or DatabaseDataSourceClient)
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110816
Component: data | Resolution:
source | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 5.0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:14 vorner]:
> > After thinking about it more, I came up with another possible name
> > "DatabaseAccessor". It may share the same concern as that for the
> > original "DatabaseConnection", but would this one perhaps sound
> > better (while addressing my own concerns)?
> >
> > Or is there anything that can better address both concerns?
>
> Well, I used Abstraction, because I couldn't come with anything better,
Accessor looks slightly better than that. I believe it addresses Stephens
concern as well, as database accessor isn't something commonly used to
name something. So I used your idea.
Okay, then the branch is basically ready for merge, but I noticed some
of the variables and test case names still contain "conn" etc. They
should better be renamed accordingly. I don't think we need another
cycle of review just for that. Once the changed code passes compile
it should be able to be merged.
--
Ticket URL: <http://bind10.isc.org/ticket/1061#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list