BIND 10 #1198: Split DatabaseClient::Finder::find

[BIND 10 Development]

#1198: Split DatabaseClient::Finder::find
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20111220
                   Priority:  minor  |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  High   |           Total Hours:  0
Feature Depending on Ticket:         |
  Datasrc refactoring                |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jinmei


Comment:

 I am comfortable with the changes.  A couple of minor points:

 findOnNameResult() needs a Doxygen header.

 The logic in logAndCreateResult() is perhaps a good example of why the
 check for unused arguments in calls to logging should be removed (as
 mentioned in the
 [https://lists.isc.org/pipermail/bind10-dev/2011-December/002908.html post
 on bind10-dev] today.  Without it, the LOG_DEBUG call could be reduced to:
 {{{
 LOG_DEBUG(logger, DBG_TRACE_DETAILED, log_id).
           arg(accessor_->getDBName()).arg(name).
           arg(type).arg(getClass()).
           arg(wildname == NULL ? "" : *wildname).
           arg(rrset == NULL ? "" : *rrset);
 }}}
 ... with the different message descriptions omitting %5 and %6 as
 required.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1198#comment:24>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development