BIND 10 #1198: Split DatabaseClient::Finder::find

[BIND 10 Development]

#1198: Split DatabaseClient::Finder::find
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20111220
                   Priority:  minor  |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  High   |           Total Hours:  0
Feature Depending on Ticket:         |
  Datasrc refactoring                |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:24 stephen]:
 > I am comfortable with the changes.  A couple of minor points:
 >
 > findOnNameResult() needs a Doxygen header.

 I know that, but thought it was homework of the main author of the
 ticket:-)  But it was me who proposed this method anyway, so I wrote
 the documentation and pushed it.

 If it looks okay, please feel free to merge.

 > The logic in logAndCreateResult() is perhaps a good example of why the
 check for unused arguments in calls to logging should be removed (as
 mentioned in the
 [https://lists.isc.org/pipermail/bind10-dev/2011-December/002908.html post
 on bind10-dev] today.  Without it, the LOG_DEBUG call could be reduced to:
 > {{{
 > LOG_DEBUG(logger, DBG_TRACE_DETAILED, log_id).
 >           arg(accessor_->getDBName()).arg(name).
 >           arg(type).arg(getClass()).
 >           arg(wildname == NULL ? "" : *wildname).
 >           arg(rrset == NULL ? "" : *rrset);
 > }}}
 > ... with the different message descriptions omitting %5 and %6 as
 required.

 Yes, I was aware of that kind of extension.  That's a tradeoff issue
 between safety and convenience, and I'm not sure right now which
 should be considered more important, but that's certainly worth a
 discussion.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1198#comment:25>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development