BIND 10 #1452: add UDP socket passing to fd_X handling
BIND 10 Development
do-not-reply at isc.org
Tue Dec 20 17:38:40 UTC 2011
#1452: add UDP socket passing to fd_X handling
-------------------------------------+-------------------------------------
Reporter: jelte | Owner: jinmei
Type: task | Status: reviewing
Priority: minor | Milestone:
Component: DDNS | Sprint-20120110
Keywords: | Resolution:
Defect Severity: N/A | Sensitive: 0
Feature Depending on Ticket: DDNS | Sub-Project: DNS
Add Hours to Ticket: 0 | Estimated Difficulty: 5
Internal?: 0 | Total Hours: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:17 vorner]:
> > As I worked on the python wrapper part of this task I noticed I
> > overlooked a few more corner cases in this branch. So I revised the
> > branch to handle these cases. Could you check these changes, too?
>
> These look OK.
>
> Anyway, it started to fail to compile for me. It doesn't seem anything
relevant changed here, though.
>
> {{{
> cc1plus: warnings being treated as errors
> ../../../../../src/lib/util/io/fd_share.cc: In function ‘int
isc::util::io::recv_fd(int)’:
> ../../../../../src/lib/util/io/fd_share.cc:106:47: error: dereferencing
type-punned pointer will break strict-aliasing rules
[...]
> }}}
>
> Did you do anything regarding it? I guess we should try to be aliasing
save, and if not, disable the strict aliasing uptimisations for the given
objects.
Ah, sorry, yes, I removed this from Makefile.am
{{{
libutil_io_la_CXXFLAGS = $(AM_CXXFLAGS) -fno-strict-aliasing
}}}
as I thought it was because we previously compiled this with
dependency on asio (which requires -fno-strict-aliasing) and we now
didn't need it (and in fact it compiled for me without the flag). It
was apparently too aggressive.
Since it's not directly related to the subject of this branch I could
revert to the original setting. But I also think it's a good
opportunity to make it cleaner. I believe the attached diff
(makefile.diff) should solve the compilation problem for you.
(Assuming so) I'm okay either with applying this cleanup or with
reverting to the previous Makefile.am
--
Ticket URL: <http://bind10.isc.org/ticket/1452#comment:20>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list