BIND 10 #1452: add UDP socket passing to fd_X handling
BIND 10 Development
do-not-reply at isc.org
Tue Dec 20 17:45:30 UTC 2011
#1452: add UDP socket passing to fd_X handling
-------------------------------------+-------------------------------------
Reporter: jelte | Owner: jinmei
Type: task | Status: reviewing
Priority: minor | Milestone:
Component: DDNS | Sprint-20120110
Keywords: | Resolution:
Defect Severity: N/A | Sensitive: 0
Feature Depending on Ticket: DDNS | Sub-Project: DNS
Add Hours to Ticket: 0 | Estimated Difficulty: 5
Internal?: 0 | Total Hours: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:18 vorner]:
> About the python part, I noticed just one thing. In the
`SocketSessionReceiver_init` function, what would happen in case the
object didn't have a fileno method at all or if the call raised an
exception? It doesn't seem to be explicitly handled, maybe it is handled
implicitly somehow. But in such case, it would deserve a comment at last I
think.
I thought I clarified that here:
{{{#!c++
} catch (const PyCPPWrapperException& ex) {
// This could happen due to memory allocation failure, but it's
more
// likely that the object doesn't have the "fileno()" method or it
// returns an unexpected type of value. So we adjust the error
// message accordingly.
PyErr_SetString(PyExc_TypeError, "Failed to parse parameter, "
"probably not a valid socket object");
}}}
but apparently it was not sufficient or very clear. I tried to
provide some more comments. How about that?
--
Ticket URL: <http://bind10.isc.org/ticket/1452#comment:21>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list