BIND 10 #928: Add statistics category into spec file of each module, and update cfgmgr to handle it
BIND 10 Development
do-not-reply at isc.org
Wed Jul 13 14:57:57 UTC 2011
#928: Add statistics category into spec file of each module, and update cfgmgr to
handle it
-------------------------------------+-------------------------------------
Reporter: | Owner: naokikambe
naokikambe | Status: reviewing
Type: | Milestone:
enhancement | Sprint-20110802
Priority: major | Resolution:
Component: | Sensitive: 0
configuration | Sub-Project: DNS
Keywords: | Estimated Difficulty: 5.0
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => naokikambe
Comment:
I think it would be wise to also add some code to check the specification
of the statistics itself; see the function check_data_specification() in
module_spec.cc (which starts the checks for config items and commands).
Looks like right now the actual specs for statistics are the same as those
for config items so a new function check_statistics_item_list could
probably be a copy of that (or it could just call that function if they
are exactly the same). I'm worried that if we make a mistake in the specs
for statistics it'll fail at a seemingly random point later.
Are statistics mandatory in a spec? (i see there are a lot places where
statistics is defined in the specfile for a module but it's just an empty
list) Not that I have a big problem with that but if they are optional we
probably don't need that.
meta-question: what's the final commit there? a merge of the branch
itself? (3225575a1d7dc447b802efe5cc15687465acbbc4)
--
Ticket URL: <http://bind10.isc.org/ticket/928#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list