BIND 10 #928: Add statistics category into spec file of each module, and update cfgmgr to handle it

[BIND 10 Development]

#928: Add statistics category into spec file of each module, and update cfgmgr to
handle it
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  naokikambe                         |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110802
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  configuration                      |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by naokikambe):

 * owner:  naokikambe => jelte


Comment:

 Thank you for reviewing.

 Replying to [comment:6 jelte]:
 > I think it would be wise to also add some code to check the
 specification of the statistics itself; see the function
 check_data_specification() in module_spec.cc (which starts the checks for
 config items and commands). Looks like right now the actual specs for
 statistics are the same as those for config items so a new function
 check_statistics_item_list could probably be a copy of that (or it could
 just call that function if they are exactly the same). I'm worried that if
 we make a mistake in the specs for statistics it'll fail at a seemingly
 random point later.

 That's right. I added check_statistics_item_list and the related methods
 into module_spec.cc.
 Please see git e454c03a1226fbc90d7f58229a91f3e4bc3775c3 in trac929 (not in
 trac928, Sorry for confusion.)

 > Are statistics mandatory in a spec? (i see there are a lot places where
 statistics is defined in the specfile for a module but it's just an empty
 list) Not that I have a big problem with that but if they are optional we
 probably don't need that.

 Not mandatory. I removed empty statistics categories. Please see git
 7018b05373f706d54a6a0fc2d8977c44292b273f in trac928.

 > meta-question: what's the final commit there? a merge of the branch
 itself? (3225575a1d7dc447b802efe5cc15687465acbbc4)

 I mistook pushing. I repushed in forcely. Please repull from the remote
 branches.

 Sorry for inconvenience.

-- 
Ticket URL: <http://bind10.isc.org/ticket/928#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development