BIND 10 #910: TSIG + TC bit support

[BIND 10 Development]

#910: TSIG + TC bit support
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110802
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  DNSPacket API                      |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jinmei


Comment:

 Reviewed commit dfd8332b1a958ed9aeb6ae423ea937b5e08024f8

 Only two points:

 '''src/lib/dns/tests/testdata/gen-wiredata.py.in'''
 I assume this is OK, but as I've mentioned before there is little
 documentation.  As we are about to start on a programme of increasing the
 support for RR types in BIND 10, can I suggest that we create a ticket to
 properly document this utility?

 '''src/lib/dns/tsig.cc'''
 getHMAC(): The description is "create an HMAC object", whereas the method
 name is getHAMC() (implying it returns the class attribute, regardless of
 what it is).  Also, the getHMAC() has the side-effect of deleting the
 stored HMAC if one exists.  Suggest renaming the method to something like
 createHMAC() or constructHMAC(), and making clear that the hmac_ created
 in the constructor is not expected to be retained.

 !ChangeLog entry is OK

 I don't need to see this again - please merge after you updated the
 getHMAC name/documentation.

-- 
Ticket URL: <http://bind10.isc.org/ticket/910#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development