BIND 10 #910: TSIG + TC bit support

[BIND 10 Development]

#910: TSIG + TC bit support
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110802
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  DNSPacket API                      |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:10 stephen]:

 > '''src/lib/dns/tests/testdata/gen-wiredata.py.in'''
 > I assume this is OK, but as I've mentioned before there is little
 documentation.  As we are about to start on a programme of increasing the
 support for RR types in BIND 10, can I suggest that we create a ticket to
 properly document this utility?

 Ah, nice reminder.  And there's already a ticket for that, #904:-)
 I've moved it to next-sprint-proposed.

 > '''src/lib/dns/tsig.cc'''
 > getHMAC(): The description is "create an HMAC object", whereas the
 method name is getHAMC() (implying it returns the class attribute,
 regardless of what it is).  Also, the getHMAC() has the side-effect of
 deleting the stored HMAC if one exists.  Suggest renaming the method to
 something like createHMAC() or constructHMAC(), and making clear that the
 hmac_ created in the constructor is not expected to be retained.

 Actually createHMAC() is not really 100% accurate in that it may
 simply return a stored object.  But it's not a public method, so the
 naming wouldn't matter much anyway.  I've simply adopted the name
 "createHMAC()" with some additional comments (not really sure if the
 comments are something you wanted.  Please check).

 I've merged the code to master.  Will close ticket.

 Thanks for the prompt review.

-- 
Ticket URL: <http://bind10.isc.org/ticket/910#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development