BIND 10 #1003: root logger names

[BIND 10 Development]

#1003: root logger names
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  jinmei
                       Type:  task   |                Status:  reviewing
                   Priority:  major  |             Milestone:
                  Component:         |  Sprint-20110802
  logging                            |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  Core
Feature Depending on Ticket:         |  Estimated Difficulty:  2.0
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jinmei


Comment:

 >b10Prefix(): I don't see the need for cast. According to
 http://www.cplusplus.com/reference/clibrary/cctype/tolower/ "The value is
 returned as an int value that can be implicitly casted to char."
 OK, removed.  (I've never really understood why toupper()/tolower() take
 ints as arguments and return int - I think I've only ever used them in the
 context of passing in a char and converting the result to a char.)

 >This comment seems to be a verbatim copy of the ticket description, and
 doesn't 100% match what the function specifically does
 I've rewritten the header comment.


 > What does 'return as const' mean? Perhaps you intended to make the
 return value of this function !ConstElementPtr??
 Good catch, I did.  I've also updated the associated comment.

 >This doesn't parse...
 Fixed.

 > Is it safe to call LOG_xxx in getRelatedLoggers(). I don't follow all
 possible control flows, but this seems to be producing a log message while
 configuring logging, which looks fragile.
 In this case it is OK.  The messages are generated during the parsing of
 the configuration and construction of the data structure used to modify
 the logging.  During this process, messages can be safely logged using
 whatever is the current logging configuration.


 > CONFIG_LOG_EXPLICIT: s/will updated/will be updated/?
 > same for CONFIG_LOG_WILD_MATCH.
 Well spotted.

 >why adding iostream? The other changes to this file don't seem to require
 it (at least not directly)
 Left over from debugging a problem.  Removed.

 >CCSessionTest() constructor: not a big deal, but I'd make root_name const
 and initialize it in the initialization list.
 Good point.  Done.

 >I'd test the case where the input name is "b10-test".
 Good thought.  Added.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1003#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development